Condition monitoring of rotating electrical machinery has received intense research interest for more than 30 years. However, electrical machinery has been considered reliable and the application of fast-acting digital electrical protection has rather reduced the attention operators pay to the equipment. The area based upon current literature and the author's experience is reviewed. There are three restrictions: only on-line techniques for rotating machines are dealt with; specific problems of variable speed drives are not dealt with, except in passing; conventional rather than emerging brushless, reluctance and permanent magnet machines of unusual topology are concentrated upon. The art of condition monitoring is minimalist, to take minimum measurements from a machine necessary to extract a diagnosis, so that a condition can be rapidly inferred, giving a clear indication of incipient failure modes. The current state of the art is reviewed in the following ways: survey developments in condition monitoring of machines, mechanically and electrically, over the last 30 years; put that work in context alongside the known failure mechanisms; review those developments which have proved successful and identify areas of research which require attention in the future to advance the subject.